Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14639#discussion_r75117822
--- Diff: R/pkg/R/sparkR.R ---
@@ -344,6 +344,7 @@ sparkRHive.init <- function(jsc = NULL) {
#' @note sparkR.session since 2.0.0
sparkR.session <- function(
master = "",
+ deployMode = "",
--- End diff --
I don't think we should add the parameter in the middle which would break
user passing parameter by order.
On the other hand, do we need this as a formal parameter? Most cluster
setup I know of is already having deploy mode in spark conf - and to @shivaram
's point, why isn't SPARK_HOME set? If it is, we wouldn't be downloading
anyway, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
