Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14538#discussion_r75189981
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -135,32 +135,62 @@ object functions {
//////////////////////////////////////////////////////////////////////////////////////////////
/**
+ * @group agg_funcs
+ * @since 1.3.0
+ */
+ @deprecated("Use approx_count_distinct()", "2.1.0")
--- End diff --
This is super minor - but `approx_count_distinct takes` arguments and the
deprecation notice could maybe be improved a little by showing that (or at
least not showing `()` - although looking at the current deprecation warnings
we do appear to use both styles so matter of personal preference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
