Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Thanks - I think this is reasonable.
Could we revisit if we are adding `...` a lot in function definition just
because the generic has it? Also those case we would be documenting `...` as
"currently not used" or similar, correct (since the definition didn't have it
before)?
I agree this is likely the most compatible approach.
_____________________________
From: Xiangrui Meng
<[email protected]<mailto:[email protected]>>
Sent: Wednesday, August 17, 2016 3:44 PM
Subject: Re: [apache/spark] [SPARK-16508][SparkR] Fix warnings on
undocumented/duplicated arguments by CRAN-check (#14558)
To: apache/spark <[email protected]<mailto:[email protected]>>
Cc: Felix Cheung
<[email protected]<mailto:[email protected]>>, Mention
<[email protected]<mailto:[email protected]>>
@felixcheung<https://github.com/felixcheung> I agree that we shouldn't put
real documentation to generics.R. I discussed with
@junyangq<https://github.com/junyangq> offline and suggest the following:
1) If we have to put "..." in setGeneric (e.g., in order to match existing
sig or extra arguments in the function definition), then we also put ... at the
end of function declaration and document "..." there. This is done similarly in
R code base.
2) If we don't need ..., then remove it from both setGeneric and function
declaration.
Does it sound good?
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/spark/pull/14558#issuecomment-240571914>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AIjc-5XpYv8QuazqGbSMU6cpjNuuS5XXks5qg47mgaJpZM4Jfx5S>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
