Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75285419
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -54,6 +54,29 @@ private[feature] trait ChiSqSelectorParams extends Params
/** @group getParam */
def getNumTopFeatures: Int = $(numTopFeatures)
+
+ final val percentile = new DoubleParam(this, "percentile",
+ "Percentile of features that selector will select, ordered by
statistics value descending.",
+ ParamValidators.gtEq(0))
+ setDefault(percentile -> 10)
--- End diff --
I understand this means 10%, but I would expect it to be specified as 0.1.
I wonder how it's done elsewhere? I think we've not used percents. At least we
also want to validate that the value is <= 100% (or 1)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
