Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r75387160
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -788,6 +788,8 @@ class GeneralizedLinearRegressionModel private[ml] (
@Since("2.0.0")
override def write: MLWriter =
new
GeneralizedLinearRegressionModel.GeneralizedLinearRegressionModelWriter(this)
+
+ override val numFeatures: Int = coefficients.size
--- End diff --
I think adding a Since might actually be somewhat counter intuitive - how
about a Javadoc note which says that it is now defined for this model starting
in 2.1.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
