Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14705#discussion_r75423643
--- Diff: R/pkg/R/mllib.R ---
@@ -917,14 +922,14 @@ setMethod("spark.lda", signature(data =
"SparkDataFrame"),
# Returns a summary of the AFT survival regression model produced by
spark.survreg,
# similarly to R's summary().
-#' @param object A fitted AFT survival regression model
+#' @param object a fitted AFT survival regression model.
#' @return \code{summary} returns a list containing the model's
coefficients,
#' intercept and log(scale)
#' @rdname spark.survreg
#' @export
#' @note summary(AFTSurvivalRegressionModel) since 2.0.0
setMethod("summary", signature(object = "AFTSurvivalRegressionModel"),
- function(object, ...) {
+ function(object) {
--- End diff --
I really like the fact that we do not need to have `...` here in the func
definition. But I'm not sure I understand why exactly - in generics.R we have
`setGeneric("summary", function(object, ...) `, doesn't it mean we need to have
`...` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
