Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14705#discussion_r75437776
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2276,9 +2276,8 @@ setMethod("n_distinct", signature(x = "Column"),
                 countDistinct(x, ...)
               })
     
    -#' @rdname nrow
    -#' @param x Column to compute on
    -#'
    +#' @param x a Column.
    +#' @rdname n
    --- End diff --
    
    Perhaps count is a better name? I investigated a little more. In the 
generated docs, each, say \name{count} and \alias{count} can only appear in one 
doc. Otherwise the check will complain duplicate names or aliases found in 1.rd 
and 2.rd.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to