Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14613#discussion_r75565500
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1053,6 +1057,13 @@ setMethod("collect",
df[[colIndex]] <- col
} else {
colType <- dtypes[[colIndex]][[2]]
+ if (is.null(PRIMITIVE_TYPES[[colType]])) {
+ specialtype <- specialtypeshandle(colType)
+ if (!is.null(specialtype)) {
+ colType <- specialtype
--- End diff --
@felixcheung You are right. Here is a mistake. The goal of this function is
to change the `Key` for the dictionary PRIMITIVE_TYPES. The issue is because
backend returns `decimal(10,0)` as the Key. Let me review the whole PR again
and make changes as you suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
