Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14705#discussion_r75566267
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -735,6 +752,8 @@ setGeneric("between", function(x, bounds) { 
standardGeneric("between") })
     setGeneric("cast", function(x, dataType) { standardGeneric("cast") })
     
     #' @rdname columnfunctions
    +#' @param x a Column object.
    +#' @param ... additional argument(s).
    --- End diff --
    
    Ah I recall. These are generated by code but are exported functions - you 
see their names match the generics.
    
    For these I think we should put the roxygen block in the R file that has 
the generator code, follow by NULL like what we have for write.ml in mllib.R
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to