Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r75571723
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala
---
@@ -88,14 +90,30 @@ case class AnalyzeTableCommand(tableName: String)
extends RunnableCommand {
}
}.getOrElse(0L)
- // Update the Hive metastore if the total size of the table is
different than the size
+ val needUpdate = new mutable.HashMap[String, String]()
+ if (newTotalSize > 0 && newTotalSize != oldTotalSize) {
+ needUpdate += (AnalyzeTableCommand.TOTAL_SIZE_FIELD ->
newTotalSize.toString)
+ }
+ if (!noscan) {
+ val oldRowCount =
tableParameters.get(AnalyzeTableCommand.ROW_COUNT).map(_.toLong)
+ .getOrElse(-1L)
+ val newRowCount = sparkSession.table(tableName).count()
+
+ if (newRowCount >= 0 && newRowCount != oldRowCount) {
+ needUpdate += (AnalyzeTableCommand.ROW_COUNT ->
newRowCount.toString)
+ }
+ }
+ // Update the Hive metastore if the above parameters of the table
is different than those
// recorded in the Hive metastore.
// This logic is based on
org.apache.hadoop.hive.ql.exec.StatsTask.aggregateStats().
- if (newTotalSize > 0 && newTotalSize != oldTotalSize) {
+ if (needUpdate.nonEmpty) {
+ // need to set this parameter so that we can store other
parameters like "numRows" into
+ // Hive metastore
+
needUpdate.put(AnalyzeTableCommand.STATS_GENERATED_VIA_STATS_TASK,
--- End diff --
Looks `STATS_GENERATED_VIA_STATS_TASK` is only needed to set when `noscan`
is `false`. So is it better to move this to above block `if (!noscan)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
