Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14601#discussion_r75584303
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -102,11 +102,19 @@ class SparkHadoopUtil extends Logging {
             hadoopConf.set("fs.s3n.awsSecretAccessKey", accessKey)
             hadoopConf.set("fs.s3a.secret.key", accessKey)
           }
    -      // Copy any "spark.hadoop.foo=bar" system properties into conf as 
"foo=bar"
           conf.getAll.foreach { case (key, value) =>
    +        // Copy any "spark.hadoop.foo=bar" system properties into conf as 
"foo=bar"
             if (key.startsWith("spark.hadoop.")) {
               hadoopConf.set(key.substring("spark.hadoop.".length), value)
             }
    +   // Copy any "fs.swift2d.foo=bar" properties into conf as 
"fs.swift2d.foo=bar"
    +        else if (key.startsWith("fs.swift2d")){
    +          hadoopConf.set(key, value)
    --- End diff --
    
    What's `swift2d`? It's not the swift client in `hadoop-openstack`, which is 
`fs.swift`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to