Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1845#discussion_r16428762
  
    --- Diff: bin/spark-submit ---
    @@ -17,28 +17,46 @@
     # limitations under the License.
     #
     
    +# NOTE: Any changes in this file must be reflected in 
SparkClassLauncher.scala!
    +
     export SPARK_HOME="$(cd `dirname $0`/..; pwd)"
     ORIG_ARGS=("$@")
     
     while (($#)); do
       if [ "$1" = "--deploy-mode" ]; then
    -    DEPLOY_MODE=$2
    +    SPARK_SUBMIT_DEPLOY_MODE=$2
    +  elif [ "$1" = "--properties-file" ]; then
    +    SPARK_SUBMIT_PROPERTIES_FILE=$2
       elif [ "$1" = "--driver-memory" ]; then
    -    DRIVER_MEMORY=$2
    +    export SPARK_SUBMIT_DRIVER_MEMORY=$2
       elif [ "$1" = "--driver-library-path" ]; then
         export SPARK_SUBMIT_LIBRARY_PATH=$2
       elif [ "$1" = "--driver-class-path" ]; then
         export SPARK_SUBMIT_CLASSPATH=$2
       elif [ "$1" = "--driver-java-options" ]; then
    -    export SPARK_SUBMIT_OPTS=$2
    --- End diff --
    
    I believe SPARK_SUBMIT_OPTS has become a slightly public API since some 
people have used it when scripting to avoid exactly the problem this PR is 
trying to solve. So it might be to initialize SPARK_SUBMIT_JAVA_OPTS to the 
value of SPARK_SUBMIT_OPTS with a comment that it's for compatiblity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to