Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14537#discussion_r75812657
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -237,21 +237,24 @@ private[hive] class
HiveMetastoreCatalog(sparkSession: SparkSession) extends Log
new Path(metastoreRelation.catalogTable.storage.locationUri.get),
partitionSpec)
- val inferredSchema = if (fileType.equals("parquet")) {
- val inferredSchema =
- defaultSource.inferSchema(sparkSession, options,
fileCatalog.allFiles())
- inferredSchema.map { inferred =>
- ParquetFileFormat.mergeMetastoreParquetSchema(metastoreSchema,
inferred)
+ val inferredSchema =
+ defaultSource.inferSchema(sparkSession, options,
fileCatalog.allFiles())
+ val schema = if (fileType == "parquet") {
+ // For Parquet, get correct schema by merging Metastore schema
data types
+ // and Parquet schema field names.
+ inferredSchema.map { schema =>
+ ParquetFileFormat.mergeMetastoreParquetSchema(metastoreSchema,
schema)
}.getOrElse(metastoreSchema)
} else {
- defaultSource.inferSchema(sparkSession, options,
fileCatalog.allFiles()).get
+ // For others (e.g orc), fall back to metastore schema if needed.
--- End diff --
If the fileType is not parquet, the only possible type is orc. To ensure
this is always true, we should check `fileType == "orc"`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
