Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75850916
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -69,21 +73,26 @@ class ChiSqSelectorModel @Since("1.3.0") (
* Preserves the order of filtered features the same as their indices
are stored.
* Might be moved to Vector as .slice
* @param features vector
- * @param filterIndices indices of features to filter, must be ordered
asc
+ * @param filterIndices indices of features to filter
*/
private def compress(features: Vector, filterIndices: Array[Int]):
Vector = {
+ val orderedIndices = if (isSorted(filterIndices)) {
--- End diff --
I don't think there's any point in checking whether it's sorted. `.sorted`
would ultimately do about the same thing and do no work if sorted already, so
it doesn't add much. Plus you can remove the isSorted method too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
