Github user Sherry302 commented on the issue:
https://github.com/apache/spark/pull/14768
For this piece of code:
I think lines in` if `and `else` blocks should be at same indentation as
logically they are at same level. The line
`((UnsafeInMemorySorter.SortedIterator)upstream).getCurrentPageNumber()) ` is a
logical block, and I indent 8 spaces instead of 2 spaces to make code more
readable. I think it's much better than this:
I referred to the [Oracle's Java code
conversions](http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#248)
, but not there is no exactly same case. @srowen Could you please give some
directions? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
