Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76049982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -783,27 +783,34 @@ case class TimeSub(start: Expression, interval:
Expression)
/**
* Returns the date that is num_months after start_date.
*/
+// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(start_date, num_months) - Returns the date that is
num_months after start_date.",
+ usage = "_FUNC_(start_date, num_months) - Returns the date/timestamp
that is num_months after start_date.",
extended = "> SELECT _FUNC_('2016-08-31', 1);\n '2016-09-30'")
+// scalastyle:on line.size.limit
case class AddMonths(startDate: Expression, numMonths: Expression)
--- End diff --
as it's not always date type now, should we use a new name instead of
`startDate`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
