Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13152#discussion_r76170505
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala 
---
    @@ -347,6 +347,47 @@ class BlockManagerReplicationSuite extends 
SparkFunSuite
       }
     
       /**
    +   * Test if we get the required number of peers when using random 
sampling from
    +   * RandomBlockReplicationPolicy
    +   */
    +  test(s"block replication - random block replication policy") {
    +    val numBlockManagers = 10
    +    val storeSize = 1000
    +    val blockManagers = (1 to numBlockManagers).map { i =>
    +      BlockManagerId(s"store-$i", "localhost", 1000 + i, None)
    +    }
    +    val candidateBlockManager = BlockManagerId("test-store", "localhost", 
1000, None)
    +    val replicationPolicy = new RandomBlockReplicationPolicy
    +    val blockId = "test-block"
    +
    +    (1 to 10).foreach {numReplicas =>
    +      logInfo(s"Num replicas : $numReplicas")
    --- End diff --
    
    are these logging information useful in tests?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to