Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14796#discussion_r76176921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ---
@@ -66,6 +70,7 @@ private object PostgresDialect extends JdbcDialect {
case BooleanType => Some(JdbcType("BOOLEAN", Types.BOOLEAN))
case FloatType => Some(JdbcType("FLOAT4", Types.FLOAT))
case DoubleType => Some(JdbcType("FLOAT8", Types.DOUBLE))
+ case ShortType => Some(JdbcType("SMALLINT", java.sql.Types.SMALLINT))
case t: DecimalType => Some(
--- End diff --
Hi @JoshRosen, do you mind if I ask a question please (although it is a
super minor)? It seems `java.sql.Types.SMALLINT` and `Types.SMALLINT` are
pointing the same constant. Are there a reason to do this like this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
