Github user aloknsingh commented on a diff in the pull request:
https://github.com/apache/spark/pull/14775#discussion_r76381368
--- Diff: R/pkg/NAMESPACE ---
@@ -363,4 +363,9 @@ S3method(structField, jobj)
S3method(structType, jobj)
S3method(structType, structField)
+export("newJObject")
+export("callJMethod")
+export("callJStatic")
+export("cleanup.jobj")
--- End diff --
Hi @sun-rui
Thanks for pointing this out. I look at the code and you are right in
mentioning that the jobj has the cleanup.jobj registered.
Initially, we were under the assumption that we have to register to the the
object created otherwise the jvm (running scala) won't cleanup our obj, as
there is the ref in the SparkR.
In summary,
1) For the systemML, with the information you had mentioned, we would be
fine with if it is made private also.
2) Also as you had mentioned, if package writer (on the top of sparkR)
feels that they have absolutely run the cleanup, they can call the R's explicit
"gc".
thanks,
Alok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
