Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76388360
--- Diff: python/pyspark/cloudpickle.py ---
@@ -280,7 +279,7 @@ def extract_code_globals(co):
# see if nested function have any global refs
if co.co_consts:
for const in co.co_consts:
- if type(const) is types.CodeType:
+ if isinstance(const, types.CodeType):
--- End diff --
Hm, i think this is third-party code. I'm reluctant to change it because
it's just a straight copy of the file from a particular release. Can we exclude
it from pep8?
You're welcome of course to file a bug against cloudpickle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
