Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14829#discussion_r76409541
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -188,7 +188,7 @@ class CSVFileFormat extends TextBasedFileFormat with
DataSourceRegister {
private def verifySchema(schema: StructType): Unit = {
schema.foreach { field =>
field.dataType match {
- case _: ArrayType | _: MapType | _: StructType =>
+ case _: ArrayType | _: MapType | _: StructType | NullType |
CalendarIntervalType =>
--- End diff --
A more general comment. This uses blacklisting, this is problematic when we
introduce a `DataType` which should not be written to CSV. Whitelisting is
preferred because it is more defensive (it would fail in the mentioned
scenario).
How does this work with UDTs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
