Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/14710#discussion_r76465162
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -122,7 +134,9 @@ class AppClientSuite extends SparkFunSuite with
LocalSparkContext with BeforeAnd
val ci = new AppClientInst(masterRpcEnv.address.toSparkURL)
// requests to master should fail immediately
- assert(ci.client.requestTotalExecutors(3) === false)
+ whenReady(ci.client.requestTotalExecutors(3), timeout(0.seconds)) {
success =>
--- End diff --
nit: don't use `0` timeout. It depends on the implementation and it could
check the timeout at first before running the command in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
