Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14746#discussion_r76511709
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -1294,20 +1296,29 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
           userSpecifiedColumns: Seq[(String, Option[String])],
           query: QueryContext,
           properties: Map[String, String],
    -      allowExisting: Boolean,
    +      ignoreIfExists: Boolean,
           replace: Boolean,
    -      isTemporary: Boolean): LogicalPlan = {
    +      isTemporary: Boolean,
    +      isAlterViewAsSelect: Boolean): LogicalPlan = {
    --- End diff --
    
    how about a `viewType` parameter which is an enum?
    ```
    public enum SaveMode {
      Temporary,
      Permanent,
      Either
    }
    ```
    We are going to add `global temp view` soon, so this enum will also be 
useful at that time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to