Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14815#discussion_r76512032
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -1385,18 +1385,25 @@ object EliminateOuterJoin extends Rule[LogicalPlan] 
with PredicateHelper {
      */
     object PushPredicateThroughJoin extends Rule[LogicalPlan] with 
PredicateHelper {
       /**
    -   * Splits join condition expressions into three categories based on the 
attributes required
    -   * to evaluate them.
    +   * Splits join condition expressions or filter predicates (on a given 
join's output) into three
    +   * categories based on the attributes required to evaluate them. Note 
that we explicitly exclude
    +   * on-deterministic (i.e., stateful) condition expressions in 
canEvaluateInLeft or
    --- End diff --
    
    yea, I will :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to