Github user VinceShieh commented on a diff in the pull request:
https://github.com/apache/spark/pull/14858#discussion_r76572410
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -116,8 +116,7 @@ final class QuantileDiscretizer @Since("1.6.0")
(@Since("1.6.0") override val ui
val distinctSplits = splits.distinct
if (splits.length != distinctSplits.length) {
- log.warn(s"Some quantiles were identical. Bucketing to
${distinctSplits.length - 1}" +
- s" buckets as a result.")
+ log.warn(s"Some quantiles were identical. Will return fewer buckets
than requested!")
--- End diff --
when the splits has NaN, we have to know the number of non-NaN value in the
splits to get the exact number of returned buckets, considering splits :{ -Inf,
-1, 1, Inf, NaN, NaN}, the old msg will actually get us a wrong result
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
