Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14836#discussion_r76575766
--- Diff: core/src/test/scala/org/apache/spark/AccumulatorSuite.scala ---
@@ -171,7 +173,7 @@ class AccumulatorSuite extends SparkFunSuite with
Matchers with LocalSparkContex
d.foreach {
x => acc.localValue ++= x
}
- acc.value should be ( (0 to maxI).toSet)
+ assert(acc.value == (0 to maxI).toSet)
--- End diff --
Yes, most code uses "==" instead of "should be". I would favor
standardizing on the former. However this change doesn't even standardize it
within this file. I think it's better to do it all or not at all. Removing the
extra space is trivial but at least positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
