Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1545#discussion_r16458986
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -56,9 +57,15 @@ private[spark] object StageInfo {
* shuffle dependencies. Therefore, all ancestor RDDs related to this
Stage's RDD through a
* sequence of narrow dependencies should also be associated with this
Stage.
*/
- def fromStage(stage: Stage): StageInfo = {
+ def fromStage(stage: Stage, numTasks: Option[Int] = None): StageInfo = {
--- End diff --
this is a nit, but I think this method might be better as an
updateStageInfo(numTasks: Int) method in Stage(), that creates an appropriate
StageInfo and then sets latestInfo accordingly (since I think that would make
it a little clearer to a reader what the usage of this is). Fine if you think
it's better this way though...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
