Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14855#discussion_r76690858
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
    @@ -791,11 +791,22 @@ case class ShowCreateTableCommand(table: 
TableIdentifier) extends RunnableComman
         }
       }
     
    +  // These table properties should not be included in the output statement 
of SHOW CREATE TABLE
    +  val excludedTableProperties = Set(
    +    // The following are hive-generated statistics fields
    +    "COLUMN_STATS_ACCURATE",
    +    "numFiles",
    +    "numPartitions",
    +    "numRows",
    +    "rawDataSize",
    +    "totalSize"
    +  )
    +
       private def showHiveTableProperties(metadata: CatalogTable, builder: 
StringBuilder): Unit = {
         if (metadata.properties.nonEmpty) {
           val filteredProps = metadata.properties.filterNot {
    -        // Skips "EXTERNAL" property for external tables
    -        case (key, _) => key == "EXTERNAL" && metadata.tableType == 
EXTERNAL
    +        // Skips all the stats info (See the JIRA: HIVE-13792)
    --- End diff --
    
    Not sure whether I got your point. Are you saying `getTableOption` in 
`HiveExternalCatalog`?
    
    Initially, I had the same design like you. Later, I realized we still 
use/display them in the other DDL statements, for example, `DESCRIBE EXTENDED 
TABLE`. 
    
    Let me know if my understanding is wrong. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to