Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/10896
  
    After this PR, we create the partial aggregate operator in 
`EnsureRequirements`, which makes the aggregation code harder to understand and 
also mess up `EnsureRequirements`.
    
    I have a simpler idea: 
    
    1. Correctly propagate `outputPartitioning` in `AggregateExec`, then we can 
avoid adding an exchange between a partial aggregate and a final aggregate.
    2. Add a new rule which is run after `EnsureRequirements`. In this rule, we 
can combine adjacent partial aggregate and final aggregate into one.
    
    cc @maropu @hvanhovell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to