Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14856#discussion_r76844264
  
    --- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
    @@ -99,6 +99,10 @@ test_that("spark.glm summary", {
       expect_match(out[2], "Deviance Residuals:")
       expect_true(any(grepl("AIC: 59.22", out)))
     
    +  # Test spark.glm works with regularization parameter
    +  regStats <- summary(spark.glm(training, Sepal_Width ~ Sepal_Length + 
Species, regParam = 0.3))
    +  expect_equal(regStats$aic, 136.7, tolerance = 1e-3)
    --- End diff --
    
    I remember it should match the result of `glmnet`? Perhaps you can try the 
same example there or take a look at 
https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala#L307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to