GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/14879
[SPARK-17314][Core]Use Netty's DefaultThreadFactory to enable its fast
ThreadLocal impl
## What changes were proposed in this pull request?
When a thread is a Netty's FastThreadLocalThread, Netty will use its fast
ThreadLocal implementation. It has a better performance than JDK's (See the
benchmark results in https://github.com/netty/netty/pull/4417, note: it's not a
fix to Netty's FastThreadLocal. It's just fixed an issue in Netty's benchmark
codes)
This PR just changed the ThreadFactory to Netty's DefaultThreadFactory
which will use FastThreadLocalThread. There is also a minor change to the
thread names. See
https://github.com/netty/netty/blob/netty-4.0.22.Final/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java#L94
## How was this patch tested?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark netty-thread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14879
----
commit 47a84c3ce5aeddccb6a53c6fd7a0eb5c09c62938
Author: Shixiong Zhu <[email protected]>
Date: 2016-08-30T00:20:42Z
Use Netty's DefaultThreadFactory to enable the fast ThreadLocal impl
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
