Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14718#discussion_r76886785
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -138,15 +165,25 @@ protected void serviceInit(Configuration conf) throws
Exception {
registeredExecutorFile =
new File(getRecoveryPath().toUri().getPath(), RECOVERY_FILE_NAME);
+ secretsFile = new File(getRecoveryPath().toUri().getPath(),
SECRETS_RECOVERY_FILE_NAME);
--- End diff --
Do you need `secretsFile` declared as a field? It seems to only be used in
this method.
Also, it seems all this secret loading code could be done inside an
"authEnabled" check, since `reloadCreds` does nothing if auth is disabled
anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
