Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76918174
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -235,14 +235,18 @@ class SessionCatalog(
* Note: If the underlying implementation does not support altering a
certain field,
* this becomes a no-op.
*/
- def alterTable(tableDefinition: CatalogTable): Unit = {
+ def alterTable(tableDefinition: CatalogTable, fromAnalyze: Boolean =
false): Unit = {
--- End diff --
The additional flag parameter `fromAnalyze` looks weird for me. Why would
we need to have two APIs for alter table and use a flag like this to choose
among them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
