Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2046#discussion_r16468398
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/TestSuiteBase.scala ---
    @@ -119,7 +119,12 @@ trait TestSuiteBase extends FunSuite with 
BeforeAndAfter with Logging {
       def batchDuration = Seconds(1)
     
       // Directory where the checkpoint data will be saved
    -  def checkpointDir = "checkpoint"
    +  lazy val checkpointDir = {
    +    val dir = Files.createTempDir()
    --- End diff --
    
    Ideally, delete this explicitly and recursively in the 'after' function. It 
could fail to be deleted if the JVM crashes later on. Minor though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to