Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14890#discussion_r76948645
  
    --- Diff: R/WINDOWS.md ---
    @@ -4,13 +4,23 @@ To build SparkR on Windows, the following steps are 
required
     
     1. Install R (>= 3.1) and 
[Rtools](http://cran.r-project.org/bin/windows/Rtools/). Make sure to
     include Rtools and R in `PATH`.
    +
     2. Install
     
[JDK7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html)
 and set
     `JAVA_HOME` in the system environment variables.
    +
     3. Download and install [Maven](http://maven.apache.org/download.html). 
Also include the `bin`
     directory in Maven in `PATH`.
    +
     4. Set `MAVEN_OPTS` as described in [Building 
Spark](http://spark.apache.org/docs/latest/building-spark.html).
    -5. Open a command shell (`cmd`) in the Spark directory and run `mvn 
-DskipTests -Psparkr package`
    +
    +5. Open a command shell (`cmd`) in the Spark directory and build Spark 
with 
[Maven](http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn)
 and include the `-Psparkr` profile to build the R package. For example to use 
the default Hadoop versions you can run
    +
    +    ```bash
    +    mvn -DskipTests -Psparkr package
    +    ```
    +
    +    `.\build\mvn` is a shell script so `mvn` should be used directly on 
Windows.
    --- End diff --
    
    Yes, it seems it'd be safer. Thanks for pointing this out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to