Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14659#discussion_r76952473
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2418,6 +2418,18 @@ private[spark] object Utils extends Logging {
           sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
         }
       }
    +
    +  def setCallerContext(context: String): Unit = {
    --- End diff --
    
    If this is set to return a Boolean on success, you could have a unit test 
which asserts that when called on a version of Hadoop with the resource 
`/org/apache/hadoop/ipcCallerContext.class`, that it returned true. That way 
you could assert that "on a version of Hadoop with a caller context, this code 
sets it". That will help catch any regressions in the Hadoop code breaking this 
reflection stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to