Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76968414
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+[pep8]
--- End diff --
- tox.ini kind of becames this pep8rc, indeed.
- isort only deals with sorting "import" statement, not checked by pep8,
but pylint has some checks on it
- style.yapf.ini is the configuration for yapf, which is a more aggressive
version of 'autopep8' made by google for their chrominum projects, to strictly
format all their python files. I don't recommend to enforce the usage of it,
but if one want to use it on its python file in the Spark project, he can
execute it and review the style before commiting. In an ideal wold, this would
be a mandatory formatting (on post commit hook for example), but this may take
some times before reaching this point
- .editorconfig only deals with tab space, like I said, might be put
outside of this PR if you want
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
