Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13584#discussion_r77272270 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala --- @@ -35,13 +35,37 @@ object RWrapperUtils extends Logging { */ def checkDataColumns(rFormula: RFormula, data: Dataset[_]): Unit = { if (data.schema.fieldNames.contains(rFormula.getLabelCol)) { - logWarning("data containing 'label' column, so change its name to avoid conflict") - rFormula.setLabelCol(rFormula.getLabelCol + "_output") + val newLabelName = convertToUniqueName(rFormula.getLabelCol, data.schema.fieldNames) + logWarning( + s"data containing ${rFormula.getLabelCol} column, changing its name to $newLabelName") + rFormula.setLabelCol(newLabelName) } if (data.schema.fieldNames.contains(rFormula.getFeaturesCol)) { - logWarning("data containing 'features' column, so change its name to avoid conflict") - rFormula.setFeaturesCol(rFormula.getFeaturesCol + "_output") + val newFeaturesName = convertToUniqueName(rFormula.getFeaturesCol, data.schema.fieldNames) + logWarning( + s"data containing ${rFormula.getFeaturesCol} column, changing its name to $newFeaturesName") --- End diff -- same here?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org