Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/14079
I got through everything except the tests. Can you fix the merge conflicts
(which I suspect relate to Josh's change)?
One more meta comment: there's a ton of blacklisting logic, especially in
the TSM. Do you think it would make sense to have a second TSM-specific
blacklist helper class that encapsulates all of this logic, and have the TSM
call methods from that class? It seems like the blacklisting data structures
separate nicely, and it might help the TSM to be more readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
