Github user srinathshankar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14797#discussion_r77280523
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -479,13 +480,23 @@ case class DataSource(
               }
             }
     
    +        // SPARK-17230: Resolve the partition columns so 
InsertIntoHadoopFsRelationCommand does
    +        // not need to have the query as child, to avoid to analyze an 
optimized query,
    +        // because InsertIntoHadoopFsRelationCommand will be optimized 
first.
    +        val columns = partitionColumns.map { name =>
    --- End diff --
    
    Can this be done before 
    val partitionSchema = ...
    above ? Looks like we're trying to analyze the columns there as well...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to