Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77302207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class ExternalCatalog {
def listFunctions(db: String, pattern: String): Seq[String]
+ //
--------------------------------------------------------------------------
+ // Resources
+ //
--------------------------------------------------------------------------
+
+ /**
+ * Add a JAR resource to the underlying external catalog for DDL (e.g.
CREATE TABLE) and DML
+ * (e.g., LOAD TABLE) operations.
+ *
+ * For example, when users create a Hive serde table, they can specify a
custom
+ * Serializer-Deserializer (SerDe) class. When Hive metastore is unable
to access the custom SerDe
+ * JAR (e.g., not on the Hive classpath), the JAR file must be added at
runtime using this API.
+ */
+ def addJar(path: String): Unit
--- End diff --
After hive is consolidated into data source, custom serde should be the
business of data source, not `ExternalCatalog`, right? And it is possibly that
the external catalog is not hive metastore.
However, it might be too far to bring the consideration here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
