Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14867#discussion_r77320471
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -374,15 +374,17 @@ setQuantifier
;
relation
- : left=relation
- ((CROSS | joinType) JOIN right=relation joinCriteria?
- | NATURAL joinType JOIN right=relation
- ) #joinRelation
- | relationPrimary #relationDefault
+ : relationPrimary joinRelation*
+ ;
+
+joinRelation
+ : joinType JOIN right=relationPrimary joinCriteria?
+ | NATURAL joinType JOIN right=relationPrimary
;
--- End diff --
I think `NATURAL CROSS JOIN` is invalid, so perhaps we should not include
`CROSS` in `joinType`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
