Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14888#discussion_r77427610
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -240,54 +240,45 @@ case class InsertIntoHiveTable(
// holdDDLTime will be true when TOK_HOLD_DDLTIME presents in the
query as a hint.
val holdDDLTime = false
if (partition.nonEmpty) {
-
- // loadPartition call orders directories created on the iteration
order of the this map
- val orderedPartitionSpec = new util.LinkedHashMap[String, String]()
- table.hiveQlTable.getPartCols.asScala.foreach { entry =>
- orderedPartitionSpec.put(entry.getName,
partitionSpec.getOrElse(entry.getName, ""))
- }
-
- // inheritTableSpecs is set to true. It should be set to false for
an IMPORT query
- // which is currently considered as a Hive native command.
- val inheritTableSpecs = true
- // TODO: Correctly set isSkewedStoreAsSubdir.
--- End diff --
This TODO is removed. We set it in `HiveClientImpl`.
cc @cloud-fan @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
