Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14444
Can you suggest an other approach to prevent duplication of the code that
constructs the 'named' arguments?
On Sep 3, 2016 19:16, "Herman van Hovell" <notificati...@github.com> wrote:
> @eyalfa <https://github.com/eyalfa> there are IMO still two more things
> to do:
>
> 1. Get rid of the CreateStructLikeFactory; that is way to complicated
> for what you are trying to do.
> 2. Touch up the tests in order to be more consistent with the rest of
> Spark.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/14444#issuecomment-244555304>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ABFFOQ2Uk0Lbn_X_qb2jyO-zcsgipk42ks5qmZ1NgaJpZM4JaDJr>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
