Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/14952#discussion_r77459444
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -520,10 +520,11 @@ private[spark] class BlockManager(
*
* This does not acquire a lock on this block in this JVM.
*/
- private def getRemoteValues(blockId: BlockId): Option[BlockResult] = {
+ private def getRemoteValues[T: ClassTag](blockId: BlockId):
Option[BlockResult] = {
+ val ct = implicitly[ClassTag[T]]
getRemoteBytes(blockId).map { data =>
val values =
- serializerManager.dataDeserializeStream(blockId,
data.toInputStream(dispose = true))
+ serializerManager.dataDeserializeStream(blockId,
data.toInputStream(dispose = true))(ct)
--- End diff --
I'm not saying this should definitely be done one way or the other, but I'm
curious why you have a preference for the extra code and more verbose API that
come with making the classTag an explicit parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
