Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77559438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -604,6 +604,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
}.toList
}
+ // TODO: Fix toJSON so that we can more safely handle Map and Seq with
loop.
--- End diff --
I removed this comments. I tried, but it seems it requires a big block to
explain what this TODO mean. I feel it may creates bigger confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
