Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1935#discussion_r16511535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -454,6 +536,11 @@ abstract class CodeGenerator[InType <: AnyRef, OutType
<: AnyRef] extends Loggin
protected def accessorForType(dt: DataType) =
newTermName(s"get${primitiveForType(dt)}")
protected def mutatorForType(dt: DataType) =
newTermName(s"set${primitiveForType(dt)}")
+ protected def hashSetForType(dt: DataType) = dt match {
--- End diff --
That is correct, the planner will not use code generation unless the type
of the count distinct is a single int or long value. Good idea though, I've
added the check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
