Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15004#discussion_r77956925
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -305,6 +305,19 @@ class HiveDDLSuite
         }
       }
     
    +  private def checkMisuseForAlterTableOrView(sqlText: String, isAlterView: 
Boolean): Unit = {
    --- End diff --
    
    I'd like to create a `assertErrorForAlterTableOnView`, which only checks 
ALTER TABLE when the table is a view. For ALTER VIEW when table is not a view, 
we can create a new method, or just duplicate the code if the test cases are 
not many.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to