Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78104317
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +411,9 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
tableDefinition
}
- if (DDLUtils.isDatasourceTable(withStatsProps)) {
+ if (tableDefinition.tableType == VIEW) {
+ client.alterTable(withStatsProps)
+ } else {
val oldDef = client.getTable(db, withStatsProps.identifier.table)
// Sets the `schema`, `partitionColumnNames` and `bucketSpec` from
the old table definition,
// to retain the spark specific format if it is. Also add old data
source properties to table
--- End diff --
We need to update the comment and variable name `oldDataSourceProps` below.
It also affects Hive serde tables after this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
