Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1905#issuecomment-52885813
>How do you plan to resolve the protobuf version requirement/conflict (akka
2.3 specifically requires protobuf 2.5, hadoop1 specifically requires 2.4), I
think currently this patch is still using 2.4
@avati I was waiting for akka shaded artifact to be published.
>Is it really necessary to import all of SparkILoop.scala? From what I
understand for 2.11 (and onwards) we can have a scala version independent repl
without having to import any such code from scala. I have a prototype
implementation of such a repl (2.11+ based) I did for Mahout, which seems to be
much smaller/simpler.
Yes, AFAIU. Because spark needs to change the code wrappers, even the class
based wrappers. I tried minimizing the porting effort but it seems there was no
easy alternative. I still feel, you may have an idea on not porting the repl
and getting it to work. I will be happy to help you achieve that. Minimally
such a port will have to pass all suites in `ReplSuite.scala`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
